[ 
https://issues.apache.org/jira/browse/FLINK-1422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14297602#comment-14297602
 ] 

ASF GitHub Bot commented on FLINK-1422:
---------------------------------------

Github user fhueske commented on the pull request:

    https://github.com/apache/flink/pull/350#issuecomment-72098340
  
    Very good addition to the documentation! 
    I also agree with Alex (see FLINK-1422) to describe how functions can be 
configured via the constructor, i.e., that function objects are serialized and 
distributed. This is actually much more comfortable and should therefore be the 
preferred way. The Configuration object is rather a relict of former 
Stratosphere times ;-)
    
    Another small improvement would be to put a link to the Function 
configuration section into the "Passing Function to Flink" section. 


> Missing usage example for "withParameters"
> ------------------------------------------
>
>                 Key: FLINK-1422
>                 URL: https://issues.apache.org/jira/browse/FLINK-1422
>             Project: Flink
>          Issue Type: Improvement
>          Components: Documentation
>    Affects Versions: 0.8
>            Reporter: Alexander Alexandrov
>            Assignee: Chesnay Schepler
>            Priority: Trivial
>             Fix For: 0.8.1
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> I am struggling to find a usage example of the "withParameters" method in the 
> documentation. At the moment I only see this note:
> {quote}
> Note: As the content of broadcast variables is kept in-memory on each node, 
> it should not become too large. For simpler things like scalar values you can 
> simply make parameters part of the closure of a function, or use the 
> withParameters(...) method to pass in a configuration.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to