Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/357#issuecomment-72614433
Looks good to me so far, modulo two comments:
- Since the type extractor code is changed a lot, it would be good to
have a test validating that the TypeExtractor allows abstract types and
interfaces.
- I would change the log level of the messages (abstract types are less
performant, type is no POJO) to INFO, since WARN implies to me that something
is wrong (which is not)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
