Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/317#issuecomment-72618925
I think this is a good fix, overall. There is one issue I would really like
to fix, and that is the serializability of the `Instance` class. This class is
not meant to be serialized and moved around, which can be reflected by the fact
that it holds an Actor Ref, and the necessity to make a lot of the fields
transient.
I assume that the instance needs to be serialized as part of the
ExechutionGraph archiving, where the ExecutionGraph is sent via an actor
message to the archiver.
I would like to solve that differently. The execution graph is "cleaned"
before archiving (see #344 ) to reduce memory footprint. At this point, I would
replace the `Instance` in the Executions with the `Instance Connection Info`,
which holds all info necessary. Then we won't have to send instances through
actor messages, which would be the cleaner solution.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
