[ 
https://issues.apache.org/jira/browse/FLINK-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14305120#comment-14305120
 ] 

ASF GitHub Bot commented on FLINK-1471:
---------------------------------------

Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/359#discussion_r24085204
  
    --- Diff: 
flink-java/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractor.java 
---
    @@ -680,10 +680,20 @@ private static void validateInputType(Type t, 
TypeInformation<?> inType) {
                }
        }
        
    -   private static void validateInputType(Class<?> baseClass, Class<?> 
clazz, int inputParamPos, TypeInformation<?> inType) {
    +   private static void validateInputType(Class<?> baseClass, Class<?> 
clazz, int inputParamPos, TypeInformation<?> inTypeInfo) {
                ArrayList<Type> typeHierarchy = new ArrayList<Type>();
    +
    +           // try to get generic parameter
    +           Type inType;
    +           try {
    +                   inType = getParameterType(baseClass, typeHierarchy, 
clazz, inputParamPos);
    +           }
    +           catch (Exception e) {
    +                   return; // skip input validation e.g. for raw types
    --- End diff --
    
    I know its annoying to change pull requests for these minor changes.
    If you want you can change it and push it to `master`.


> Allow KeySelectors to implement ResultTypeQueryable
> ---------------------------------------------------
>
>                 Key: FLINK-1471
>                 URL: https://issues.apache.org/jira/browse/FLINK-1471
>             Project: Flink
>          Issue Type: Bug
>          Components: Java API
>    Affects Versions: 0.9
>            Reporter: Robert Metzger
>            Assignee: Timo Walther
>             Fix For: 0.9
>
>
> See https://github.com/apache/flink/pull/354



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to