[
https://issues.apache.org/jira/browse/FLINK-1543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14320688#comment-14320688
]
ASF GitHub Bot commented on FLINK-1543:
---------------------------------------
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/394#discussion_r24693247
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskManagerTest.java
---
@@ -486,7 +489,8 @@ protected void run() {
public void onReceive(Object message) throws Exception {
if(message instanceof
RegistrationMessages.RegisterTaskManager){
final InstanceID iid = new InstanceID();
- getSender().tell(new
RegistrationMessages.AcknowledgeRegistration(iid, -1),
+ getSender().tell(new
RegistrationMessages.AcknowledgeRegistration(iid, -1,
+
Option.<ActorRef>apply(null)),
--- End diff --
I think that `apply(null)` is actually a `Some`, not a `None`.
> Proper exception handling in actors
> -----------------------------------
>
> Key: FLINK-1543
> URL: https://issues.apache.org/jira/browse/FLINK-1543
> Project: Flink
> Issue Type: Improvement
> Reporter: Till Rohrmann
>
> With Akka's actors it is important to not throw exceptions in the actor
> thread, if one does not want that the actor restarts or stops. Many of the
> Java components which are called from the actor's receive method throw
> exceptions which are not properly handled by the actor thread. Therefore, we
> have to catch these exceptions and handle them properly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
