[ 
https://issues.apache.org/jira/browse/FLINK-1417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14322736#comment-14322736
 ] 

ASF GitHub Bot commented on FLINK-1417:
---------------------------------------

Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/393#discussion_r24749284
  
    --- Diff: 
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java ---
    @@ -292,7 +360,76 @@ public void registerKryoType(Class<?> type) {
        /**
         * Returns the registered POJO types.
         */
    -   public Set<Class<?>> getRegisteredPojoTypes() {
    +   public List<Class<?>> getRegisteredPojoTypes() {
                return registeredPojoTypes;
        }
    +
    +
    +   public boolean isDisableAutoTypeRegistration() {
    +           return disableAutoTypeRegistration;
    +   }
    +
    +   /**
    +    * Control whether Flink is automatically registering all types in the 
user programs with
    +    * Kryo.
    +    *
    +    * @param disableAutoTypeRegistration
    +    */
    +   public void setDisableAutoTypeRegistration(boolean 
disableAutoTypeRegistration) {
    --- End diff --
    
    I would prefer "disableAutoTypeRegistration" here. And then 
"isAutoTypeRegistrationDisabled", above.


> Automatically register nested types at Kryo
> -------------------------------------------
>
>                 Key: FLINK-1417
>                 URL: https://issues.apache.org/jira/browse/FLINK-1417
>             Project: Flink
>          Issue Type: Improvement
>          Components: Java API, Scala API
>            Reporter: Stephan Ewen
>            Assignee: Robert Metzger
>             Fix For: 0.9
>
>
> Currently, the {{GenericTypeInfo}} registers the class of the type at Kryo. 
> In order to get the best performance, it should recursively walk the classes 
> and make sure that it registered all contained subtypes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to