Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/413#discussion_r25086186
  
    --- Diff: 
flink-java/src/main/java/org/apache/flink/api/java/typeutils/GenericTypeInfo.java
 ---
    @@ -66,6 +71,9 @@ public boolean isKeyType() {
     
        @Override
        public TypeSerializer<T> createSerializer() {
    +           if(useAvroSerializer) {
    +                   return new AvroSerializer<T>(this.typeClass);
    +           }
                return new KryoSerializer<T>(this.typeClass);
    --- End diff --
    
    If we enclose the ```return new KryoSerializer``` in an else block, then 
the control flow looks nicer imho.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to