[
https://issues.apache.org/jira/browse/FLINK-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14329215#comment-14329215
]
ASF GitHub Bot commented on FLINK-1567:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/413#discussion_r25086186
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/typeutils/GenericTypeInfo.java
---
@@ -66,6 +71,9 @@ public boolean isKeyType() {
@Override
public TypeSerializer<T> createSerializer() {
+ if(useAvroSerializer) {
+ return new AvroSerializer<T>(this.typeClass);
+ }
return new KryoSerializer<T>(this.typeClass);
--- End diff --
If we enclose the ```return new KryoSerializer``` in an else block, then
the control flow looks nicer imho.
> Add option to switch between Avro and Kryo serialization for GenericTypes
> -------------------------------------------------------------------------
>
> Key: FLINK-1567
> URL: https://issues.apache.org/jira/browse/FLINK-1567
> Project: Flink
> Issue Type: Improvement
> Affects Versions: 0.8, 0.9
> Reporter: Robert Metzger
> Assignee: Robert Metzger
>
> Allow users to switch the underlying serializer for GenericTypes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
