Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/436#discussion_r25268693
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/deployment/PartitionInfo.java
---
@@ -143,7 +147,14 @@ public static PartitionInfo fromEdge(ExecutionEdge
edge, SimpleSlot consumerSlot
}
}
- return new PartitionInfo(partitionId, producerExecutionId,
producerLocation, producerAddress);
+ PartitionInfo partitionInfo = new PartitionInfo(partitionId,
producerExecutionId,
+ producerLocation, producerAddress);
+
+ if (LOG.isDebugEnabled()) {
--- End diff --
Just small nit, since we are now using SLF4J, we no longer need to do guard
for simple debug logging [1]. Hopefully to get the code less busy =)
[1] http://slf4j.org/faq.html#logging_performance
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
