[
https://issues.apache.org/jira/browse/FLINK-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14335076#comment-14335076
]
ASF GitHub Bot commented on FLINK-1568:
---------------------------------------
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/436#discussion_r25268693
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/deployment/PartitionInfo.java
---
@@ -143,7 +147,14 @@ public static PartitionInfo fromEdge(ExecutionEdge
edge, SimpleSlot consumerSlot
}
}
- return new PartitionInfo(partitionId, producerExecutionId,
producerLocation, producerAddress);
+ PartitionInfo partitionInfo = new PartitionInfo(partitionId,
producerExecutionId,
+ producerLocation, producerAddress);
+
+ if (LOG.isDebugEnabled()) {
--- End diff --
Just small nit, since we are now using SLF4J, we no longer need to do guard
for simple debug logging [1]. Hopefully to get the code less busy =)
[1] http://slf4j.org/faq.html#logging_performance
> Add failure-case tests for data exchange
> ----------------------------------------
>
> Key: FLINK-1568
> URL: https://issues.apache.org/jira/browse/FLINK-1568
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Runtime
> Affects Versions: master
> Reporter: Ufuk Celebi
>
> There are currently no tests of the distributed runtime data exchange in
> failure scenarios.
> The tests need to verify how errors are propagated to the tasks and how they
> affect the state of the exchanged intermediate result.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
