Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/426#discussion_r26206329
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/io/CsvInputFormat.java ---
@@ -234,9 +291,29 @@ public OUT readRecord(OUT reuse, byte[] bytes, int
offset, int numBytes) throws
}
if (parseRecord(parsedValues, bytes, offset, numBytes)) {
- // valid parse, map values into pact record
- for (int i = 0; i < parsedValues.length; i++) {
- reuse.setField(parsedValues[i], i);
+ if (typeInformation instanceof TupleTypeInfoBase) {
+ // result type is tuple
+ Tuple result = (Tuple) reuse;
+ for (int i = 0; i < parsedValues.length; i++) {
+ result.setField(parsedValues[i], i);
+ }
+ } else {
+ // result type is POJO
+ PojoTypeInfo<OUT> pojoTypeInfo =
(PojoTypeInfo<OUT>) typeInformation;
+ for (int i = 0; i < parsedValues.length; i++) {
+ if (fieldsMap[i] == null) {
+ continue;
+ }
+
+ try {
+ int fieldIndex =
typeInformation.getFieldIndex(fieldsMap[i]);
--- End diff --
We could compute the index upfront and avoid the String look-up.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
