[ 
https://issues.apache.org/jira/browse/FLINK-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14356960#comment-14356960
 ] 

ASF GitHub Bot commented on FLINK-1512:
---------------------------------------

Github user fhueske commented on the pull request:

    https://github.com/apache/flink/pull/426#issuecomment-78276533
  
    Hi, thanks for the update! This is really good progress!
    
    I had a look at your code and noticed a few things apart from the inline 
comments.
    - PojoTypeInformation is unfortunately not serializable (as I had to learn 
a few days ago myself) because ``java.lang.reflect.Field`` is not serializable. 
So the InputFormat will not work if used in a complete Flink program. What you 
need to do to get the IF working is to add member variables for the POJO class 
and all field names. In the ``open()`` method you need to create the ``Field`` 
objects with ``clazz.getDeclaredField(fieldName)`` and use these fields in the 
``readRecord`` method.
    
    - Add (at least) two end-to-end tests for the Java API and the Scala API 
that use the new Pojo feature. These tests will catch the TypeInformation 
serialization problem.
    
    Please don't hesitate to get in touch if you have any questions!
    



> Add CsvReader for reading into POJOs.
> -------------------------------------
>
>                 Key: FLINK-1512
>                 URL: https://issues.apache.org/jira/browse/FLINK-1512
>             Project: Flink
>          Issue Type: New Feature
>          Components: Java API, Scala API
>            Reporter: Robert Metzger
>            Assignee: Chiwan Park
>            Priority: Minor
>              Labels: starter
>
> Currently, the {{CsvReader}} supports only TupleXX types. 
> It would be nice if users were also able to read into POJOs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to