[
https://issues.apache.org/jira/browse/FLINK-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14358483#comment-14358483
]
ASF GitHub Bot commented on FLINK-1677:
---------------------------------------
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/475#issuecomment-78459308
Thanks for the PR. I think it's a good fix, **but**:
I noticed that
`DegreesWithExceptionITCase.testGetDegreesInvalidEdgeSrcId`is sometimes failing
(for example here:
https://s3.amazonaws.com/archive.travis-ci.org/jobs/53985893/log.txt). I
initially thought that it was a problem of my runtime changes in #471, but the
problem is the following:
You expect a certain exception msg ("The edge src/trg id could not be found
within the vertexIds") for the test to pass. But in the getDegrees() test there
is a reducer following the coGroup (this one throws the expected exception),
which can also fail with another exception, because of the cancelling before in
the coCroup. If this other exception gets reported to the client, the test
fails.
I think it would be enough to test that the job fails or even think about
whether it makes sense to cover this in a unit test of the operator, because
imo it all boils down to the behaviour of the degree computing coGroup, which
throws the expected `NoSuchElementException`.
---
Other than that:
- Initially I thought whether you should extends MultipleProgramsTestBase
as in other test cases, but I think that doesn't work with the Exception
checking. In the future, we should add some test utils to test failing
"high-level" programs.
- Typo in the commit msg: suppres**s**ed
If you think it's OK to just test that the program is failing, go ahead and
change it. After that it would be good to merge.
> Properly Suppress Sysout Printing for the Degrees with exception test suite
> ---------------------------------------------------------------------------
>
> Key: FLINK-1677
> URL: https://issues.apache.org/jira/browse/FLINK-1677
> Project: Flink
> Issue Type: Bug
> Components: Gelly
> Affects Versions: 0.9
> Reporter: Andra Lungu
> Assignee: Andra Lungu
> Priority: Minor
>
> Suppress systout printing similar to:
> flink-clients/src/test/java/org/apache/flink/client/program/ExecutionPlanAfterExecutionTest.java
> Speedup test suite by reusing a mini-cluster similar to:
> flink-tests/src/test/java/org/apache/flink/test/recovery/SimpleRecoveryITCase.java
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
