[ 
https://issues.apache.org/jira/browse/FLINK-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14363187#comment-14363187
 ] 

ASF GitHub Bot commented on FLINK-1688:
---------------------------------------

Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/484#discussion_r26483484
  
    --- Diff: 
flink-staging/flink-streaming/flink-streaming-connectors/src/main/java/org/apache/flink/streaming/connectors/socket/SocketClientSink.java
 ---
    @@ -0,0 +1,107 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.streaming.connectors.socket;
    +
    +import java.io.DataOutputStream;
    +import java.io.IOException;
    +import java.io.OutputStream;
    +import java.net.Socket;
    +
    +import org.apache.flink.configuration.Configuration;
    +import org.apache.flink.streaming.api.function.sink.RichSinkFunction;
    +import org.apache.flink.streaming.connectors.util.SerializationSchema;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +public class SocketClientSink<IN> extends RichSinkFunction<IN> {
    --- End diff --
    
    Can you add a docstring for the class to explain its purpose?


> Add socket sink
> ---------------
>
>                 Key: FLINK-1688
>                 URL: https://issues.apache.org/jira/browse/FLINK-1688
>             Project: Flink
>          Issue Type: New Feature
>          Components: Streaming
>            Reporter: Márton Balassi
>            Priority: Trivial
>              Labels: starter
>
> Add a sink that writes output to socket. I'd consider two options, one which 
> implements a socket server and one which implements a client.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to