[
https://issues.apache.org/jira/browse/FLINK-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14365854#comment-14365854
]
ASF GitHub Bot commented on FLINK-1350:
---------------------------------------
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/471#issuecomment-82554365
Look good, nice test coverage and fits very well with the recent execution
mode changes.
Only downside: This pull request does contains many cases where only
whitespaces where changed, or the order of imports. This is not really helping
the reviews and clutters the change history of files and hinders git blame. I
know that some IDEs to that automatically, but it would be nice to deactivate
that in the future. Why the hell some IDEs think that adding 100 changed lines
to a file (where only one typo was fixed) would help is beyond me...
Minor comment: The JoinDeadlock test creates a dedicated input format that
does not do anything different then `ExecutionEnvironment#generateSequence`
would do, if the source parallelism was set to one.
> Add blocking intermediate result partitions
> -------------------------------------------
>
> Key: FLINK-1350
> URL: https://issues.apache.org/jira/browse/FLINK-1350
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Runtime
> Reporter: Ufuk Celebi
> Assignee: Ufuk Celebi
>
> The current state of runtime support for intermediate results (see
> https://github.com/apache/incubator-flink/pull/254 and FLINK-986) only
> supports pipelined intermediate results (with back pressure), which are
> consumed as they are being produced.
> The next variant we need to support are blocking intermediate results
> (without back pressure), which are fully produced before being consumed. This
> is for example desirable in situations, where we currently may run into
> deadlocks when running pipelined.
> I will start working on this on top of my pending pull request.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
