Github user balidani commented on a diff in the pull request:
https://github.com/apache/flink/pull/491#discussion_r26613854
--- Diff: flink-core/src/test/java/org/apache/flink/core/fs/PathTest.java
---
@@ -63,6 +63,15 @@ public void testPathFromString() {
assertEquals("/my/path", p.toUri().getPath());
assertEquals("file", p.toUri().getScheme());
+ p = new Path("C:/my/windows/path");
+ assertEquals("/C:/my/windows/path", p.toUri().getPath());
+
+ p = new Path("file:/C:/my/windows/path");
+ assertEquals("/C:/my/windows/path", p.toUri().getPath());
+
+ p = new Path("C:");
+ assertEquals("/C:", p.toUri().getPath());
--- End diff --
Well the test passes, not sure if it's semantically correct though. If it's
not correct, then `Path` should be changed I guess?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
