[
https://issues.apache.org/jira/browse/FLINK-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14372024#comment-14372024
]
Gyula Fora edited comment on FLINK-1763 at 3/21/15 11:40 AM:
-------------------------------------------------------------
I still think that it makes sense to have a cancel method here as that gives a
way of always closing outside connections. Otherwise the cancel method in the
StreamVertex should call the close() method of the operator.
was (Author: gyfora):
I still think that it makes sense to have a cancel method here as that gives a
way of always closing outside connections. Otherwise the cancel method in the
StreamVertex should call the close() method of the operator (which I dont think
it should).
> Remove "cancel" from streaming SinkFunction
> -------------------------------------------
>
> Key: FLINK-1763
> URL: https://issues.apache.org/jira/browse/FLINK-1763
> Project: Flink
> Issue Type: Improvement
> Components: Streaming
> Affects Versions: 0.9
> Reporter: Stephan Ewen
> Fix For: 0.9
>
>
> Since the streaming sink function is called individually for each record, it
> does not require a {{cancel()}} function. The system can cancel between calls
> to that function (which it cannot do for the source function).
> Removing this method removes the need to always implement the unnecessary,
> and usually empty, method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
