[
https://issues.apache.org/jira/browse/FLINK-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14374911#comment-14374911
]
ASF GitHub Bot commented on FLINK-1763:
---------------------------------------
GitHub user gyfora opened a pull request:
https://github.com/apache/flink/pull/513
[FLINK-1763] [streaming] Remove cancel from SinkFunction
In addition, always calls the close method of the functions even if it was
cancelled.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mbalassi/flink FLINK-1763
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/513.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #513
----
commit 9b1e00e2cb934bd8981037c82153d5fbd2b254c9
Author: Gyula Fora <[email protected]>
Date: 2015-03-22T12:44:27Z
[FLINK-1763] [streaming] Remove cancel from SinkFunction
----
> Remove "cancel" from streaming SinkFunction
> -------------------------------------------
>
> Key: FLINK-1763
> URL: https://issues.apache.org/jira/browse/FLINK-1763
> Project: Flink
> Issue Type: Improvement
> Components: Streaming
> Affects Versions: 0.9
> Reporter: Stephan Ewen
> Assignee: Gyula Fora
> Fix For: 0.9
>
>
> Since the streaming sink function is called individually for each record, it
> does not require a {{cancel()}} function. The system can cancel between calls
> to that function (which it cannot do for the source function).
> Removing this method removes the need to always implement the unnecessary,
> and usually empty, method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
