[
https://issues.apache.org/jira/browse/FLINK-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14375945#comment-14375945
]
ASF GitHub Bot commented on FLINK-1560:
---------------------------------------
Github user mbalassi commented on a diff in the pull request:
https://github.com/apache/flink/pull/519#discussion_r26939465
--- Diff:
flink-staging/flink-streaming/flink-streaming-examples/src/main/java/org/apache/flink/streaming/examples/twitter/TwitterStream.java
---
@@ -176,11 +176,14 @@ private static boolean parseParameters(String[] args)
{
// parse input arguments
fileOutput = true;
if (args.length == 2) {
+ fileInput = true;
textPath = args[0];
outputPath = args[1];
+ } else if (args.length == 1) {
+ outputPath = args[0];
} else {
System.err.println("USAGE:\nTwitterStream
<pathToPropertiesFile> <result path>");
- return false;
+ return true;
}
--- End diff --
Why return true here? This way this function always returns true.
> Add ITCases for streaming examples
> ----------------------------------
>
> Key: FLINK-1560
> URL: https://issues.apache.org/jira/browse/FLINK-1560
> Project: Flink
> Issue Type: Test
> Components: Streaming
> Affects Versions: 0.9
> Reporter: Márton Balassi
> Assignee: Péter Szabó
>
> Currently there are no tests for consistency of the streaming example
> programs. This might be a real show stopper for users who encounter an issue
> there.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
