Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/426#discussion_r26992871
  
    --- Diff: 
flink-java/src/test/java/org/apache/flink/api/java/io/CsvInputFormatTest.java 
---
    @@ -684,4 +693,249 @@ private void testRemovingTrailingCR(String 
lineBreakerInFile, String lineBreaker
                }
        }
     
    +   private void validatePojoItem(CsvInputFormat<PojoItem> format) throws 
Exception {
    +           PojoItem item = new PojoItem();
    +
    +           format.nextRecord(item);
    +
    +           assertEquals(123, item.field1);
    +           assertEquals("AAA", item.field2);
    +           assertEquals(Double.valueOf(3.123), item.field3);
    +           assertEquals("BBB", item.field4);
    +
    +           format.nextRecord(item);
    +
    +           assertEquals(456, item.field1);
    +           assertEquals("BBB", item.field2);
    +           assertEquals(Double.valueOf(1.123), item.field3);
    +           assertEquals("AAA", item.field4);
    +   }
    +
    +   @Test
    +   public void testPojoType() throws Exception {
    +           File tempFile = File.createTempFile("CsvReaderPojoType", "tmp");
    +           tempFile.deleteOnExit();
    +           tempFile.setWritable(true);
    +
    +           OutputStreamWriter wrt = new OutputStreamWriter(new 
FileOutputStream(tempFile));
    +           wrt.write("123,AAA,3.123,BBB\n");
    +           wrt.write("456,BBB,1.123,AAA\n");
    +           wrt.close();
    +
    +           @SuppressWarnings("unchecked")
    +           TypeInformation<PojoItem> typeInfo = 
(TypeInformation<PojoItem>) TypeExtractor.createTypeInfo(PojoItem.class);
    +           CsvInputFormat<PojoItem> inputFormat = new 
CsvInputFormat<PojoItem>(new Path(tempFile.toURI().toString()), typeInfo);
    +
    +           inputFormat.configure(new Configuration());
    +           FileInputSplit[] splits = inputFormat.createInputSplits(1);
    +
    +           inputFormat.open(splits[0]);
    +
    +           validatePojoItem(inputFormat);
    +   }
    +
    +   @Test
    +   public void testPojoTypeWithPrivateField() throws Exception {
    +           File tempFile = File.createTempFile("CsvReaderPojoType", "tmp");
    +           tempFile.deleteOnExit();
    +           tempFile.setWritable(true);
    +
    +           OutputStreamWriter wrt = new OutputStreamWriter(new 
FileOutputStream(tempFile));
    +           wrt.write("123,AAA,3.123,BBB\n");
    +           wrt.write("456,BBB,1.123,AAA\n");
    +           wrt.close();
    +
    +           @SuppressWarnings("unchecked")
    +           TypeInformation<PrivatePojoItem> typeInfo = 
(TypeInformation<PrivatePojoItem>) 
TypeExtractor.createTypeInfo(PrivatePojoItem.class);
    +           CsvInputFormat<PrivatePojoItem> inputFormat = new 
CsvInputFormat<PrivatePojoItem>(new Path(tempFile.toURI().toString()), 
typeInfo);
    +
    +           inputFormat.configure(new Configuration());
    +
    +           FileInputSplit[] splits = inputFormat.createInputSplits(1);
    +           inputFormat.open(splits[0]);
    +
    +           PrivatePojoItem item = new PrivatePojoItem();
    +           inputFormat.nextRecord(item);
    --- End diff --
    
    you can use the `validatePojoItem()` method here as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to