[
https://issues.apache.org/jira/browse/FLINK-1774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14377584#comment-14377584
]
ASF GitHub Bot commented on FLINK-1774:
---------------------------------------
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/522#issuecomment-85425753
Looks good, the finally block actually takes care of the cleanup.
+1 to merge
> Remove the redundant code in try{} block
> ----------------------------------------
>
> Key: FLINK-1774
> URL: https://issues.apache.org/jira/browse/FLINK-1774
> Project: Flink
> Issue Type: Improvement
> Affects Versions: master
> Reporter: Sibao Hong
> Assignee: Sibao Hong
> Priority: Minor
> Fix For: master
>
>
> Remove the redundant code of "fos.close(); fos = null;" in try block because
> the fos,close() code will always executes in finally block.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
