[ 
https://issues.apache.org/jira/browse/FLINK-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14377703#comment-14377703
 ] 

ASF GitHub Bot commented on FLINK-1512:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/426#discussion_r27018715
  
    --- Diff: 
flink-java/src/main/java/org/apache/flink/api/java/io/CsvInputFormat.java ---
    @@ -234,9 +228,21 @@ public OUT readRecord(OUT reuse, byte[] bytes, int 
offset, int numBytes) throws
                }
                
                if (parseRecord(parsedValues, bytes, offset, numBytes)) {
    -                   // valid parse, map values into pact record
    -                   for (int i = 0; i < parsedValues.length; i++) {
    -                           reuse.setField(parsedValues[i], i);
    +                   if (pojoTypeClass == null) {
    +                           // result type is tuple
    +                           Tuple result = (Tuple) reuse;
    +                           for (int i = 0; i < parsedValues.length; i++) {
    +                                   result.setField(parsedValues[i], i);
    +                           }
    +                   } else {
    +                           // result type is POJO
    +                           for (int i = 0; i < parsedValues.length; i++) {
    +                                   try {
    +                                           pojoFields[i].set(reuse, 
parsedValues[i]);
    +                                   } catch (IllegalAccessException e) {
    +                                           throw new RuntimeException(e);
    --- End diff --
    
    Add a message like `"Parsed value could not be set in POJO field \"" + 
pojoFieldsName[i] + "\""`


> Add CsvReader for reading into POJOs.
> -------------------------------------
>
>                 Key: FLINK-1512
>                 URL: https://issues.apache.org/jira/browse/FLINK-1512
>             Project: Flink
>          Issue Type: New Feature
>          Components: Java API, Scala API
>            Reporter: Robert Metzger
>            Assignee: Chiwan Park
>            Priority: Minor
>              Labels: starter
>
> Currently, the {{CsvReader}} supports only TupleXX types. 
> It would be nice if users were also able to read into POJOs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to