[
https://issues.apache.org/jira/browse/FLINK-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14379782#comment-14379782
]
ASF GitHub Bot commented on FLINK-1775:
---------------------------------------
Github user gyfora commented on a diff in the pull request:
https://github.com/apache/flink/pull/534#discussion_r27115257
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/streamvertex/StreamVertex.java
---
@@ -283,16 +288,18 @@ public StreamConfig getConfig() {
*
* @param id
*/
- private void actOnBarrier(long id) {
- try {
- outputHandler.broadcastBarrier(id);
- // TODO checkpoint state here
- confirmBarrier(id);
- if (LOG.isDebugEnabled()) {
- LOG.debug("Superstep " + id + " processed: " +
StreamVertex.this);
+ private synchronized void actOnBarrier(long id) {
+ if (this.isRunning) {
+ try {
+ outputHandler.broadcastBarrier(id);
+ // TODO checkpoint state here
+ confirmBarrier(id);
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("Superstep " + id + "
processed: " + StreamVertex.this);
+ }
+ } catch (Exception e) {
+ // TODO:Figure this out properly
--- End diff --
I had some weird exceptions after the streams finished, and in any case
this shouldnt affect the recovery logic
> BarrierBuffers don't correctly handle end of stream events
> ----------------------------------------------------------
>
> Key: FLINK-1775
> URL: https://issues.apache.org/jira/browse/FLINK-1775
> Project: Flink
> Issue Type: Bug
> Components: Streaming
> Reporter: Gyula Fora
> Assignee: Gyula Fora
>
> The current implementation causes deadlocks when the end of stream event
> comes from a currently blocked channel.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
