[
https://issues.apache.org/jira/browse/FLINK-1805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14387000#comment-14387000
]
ASF GitHub Bot commented on FLINK-1805:
---------------------------------------
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/546#discussion_r27410240
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/disk/iomanager/IOManagerAsync.java
---
@@ -43,7 +45,10 @@
/** Flag to signify that the IOManager has been shut down already */
private final AtomicBoolean isShutdown = new AtomicBoolean();
-
+
+ /** Logging */
+ protected static final Logger LOG =
LoggerFactory.getLogger(IOManagerAsync.class);
--- End diff --
Could we just use private here instead of protected?
> The class IOManagerAsync(in org.apache.flink.runtime.io.disk.iomanager)
> should use its own Log
> ----------------------------------------------------------------------------------------------
>
> Key: FLINK-1805
> URL: https://issues.apache.org/jira/browse/FLINK-1805
> Project: Flink
> Issue Type: Bug
> Components: Local Runtime
> Affects Versions: master
> Reporter: Sibao Hong
> Assignee: Sibao Hong
>
> Although class 'IOManagerAsync' is extended from 'IOManager' in package
> 'org.apache.flink.runtime.io.disk.iomanager', but I think it should has its
> own Log instance.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
