[ 
https://issues.apache.org/jira/browse/FLINK-1589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14390481#comment-14390481
 ] 

ASF GitHub Bot commented on FLINK-1589:
---------------------------------------

Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/427#discussion_r27564491
  
    --- Diff: 
flink-clients/src/main/java/org/apache/flink/client/LocalExecutor.java ---
    @@ -103,6 +110,9 @@ public void start() throws Exception {
                                
                                // create the embedded runtime
                                Configuration configuration = 
getConfiguration(this);
    +                           if(this.configuration != null) {
    +                                   
configuration.addAll(this.configuration);
    +                           }
    --- End diff --
    
    Wouldn't it be better to move the null check to the constructor and create 
the default `Configuration` there via a call to `getConfiguration`?


> Add option to pass Configuration to LocalExecutor
> -------------------------------------------------
>
>                 Key: FLINK-1589
>                 URL: https://issues.apache.org/jira/browse/FLINK-1589
>             Project: Flink
>          Issue Type: New Feature
>            Reporter: Robert Metzger
>            Assignee: Robert Metzger
>
> Right now its not possible for users to pass custom configuration values to 
> Flink when running it from within an IDE.
> It would be very convenient to be able to create a local execution 
> environment that allows passing configuration files.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to