Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/541#discussion_r27715729
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/operators/DataSink.java ---
@@ -208,6 +214,28 @@ public DataSink(DataSet<T> data, OutputFormat<T>
format, TypeInformation<T> type
return this;
}
+ private void isValidSortKeyType(int field) {
--- End diff --
There are repeating yet similar code for isValidSortKeyType methods to
check if sortable. Could the code be moved to utility class to be reused/
shared?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
