[
https://issues.apache.org/jira/browse/FLINK-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14394913#comment-14394913
]
Fabian Hueske commented on FLINK-1820:
--------------------------------------
I agree, consistency is very important!
But I am still convinced that returning a 0 value (or any other arbitrary valid
value) for a value which is not present is a bad idea.
Null values are only an option if we return values as Java classes and not as
primitive types. We recently added support for POJOs which can have primitive
values. So null values are unfortunately not an option if we strive for
consistency.
IMO, the right option would be to throw an exception. If different behavior is
desired, it should be done using custom parsers which are not supported at the
moment but could be emulated by a Mapper.
TPC-DS is just one of many benchmarks and we should not take it as a standard,
IMO.
> Bug in DoubleParser and FloatParser - empty String is not casted to 0
> ---------------------------------------------------------------------
>
> Key: FLINK-1820
> URL: https://issues.apache.org/jira/browse/FLINK-1820
> Project: Flink
> Issue Type: Bug
> Components: core
> Affects Versions: 0.8.0, 0.9, 0.8.1
> Reporter: Felix Neutatz
> Assignee: Felix Neutatz
> Priority: Critical
> Fix For: 0.9
>
>
> Hi,
> I found the bug, when I wanted to read a csv file, which had a line like:
> "||\n"
> If I treat it as a Tuple2<Long,Long>, I get as expected a tuple (0L,0L).
> But if I want to read it into a Double-Tuple or a Float-Tuple, I get the
> following error:
> java.lang.AssertionError: Test failed due to a
> org.apache.flink.api.common.io.ParseException: Line could not be parsed: '||'
> ParserError NUMERIC_VALUE_FORMAT_ERROR
> This error can be solved by adding an additional condition for empty strings
> in the FloatParser / DoubleParser.
> We definitely need the CSVReader to be able to read "empty values".
> I can fix it like described if there are no better ideas :)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
