[
https://issues.apache.org/jira/browse/FLINK-703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14481150#comment-14481150
]
ASF GitHub Bot commented on FLINK-703:
--------------------------------------
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/572#issuecomment-90023731
@hsaputra Thanks for advice! I renamed `BasicKeySelector` to
`IdentityKeySelector` to prevent ambiguous naming. I added JavaDoc for
`IdentityKeySelector`.
BTW, I found some duplicated classes with `IdentityKeySelector`
([1](https://github.com/apache/flink/blob/master/flink-optimizer/src/test/java/org/apache/flink/optimizer/testfunctions/IdentityKeyExtractor.java),
[2](https://github.com/apache/flink/blob/master/flink-tests/src/test/java/org/apache/flink/test/iterative/StaticlyNestedIterationsITCase.java#L58),
[3](https://github.com/apache/flink/blob/master/flink-tests/src/test/java/org/apache/flink/test/misc/CustomPartitioningITCase.java#L67)).
Should I substitute the `IdentityKeySelector` for them? It will decrease the
amount of duplicated code.
> Use complete element as join key.
> ---------------------------------
>
> Key: FLINK-703
> URL: https://issues.apache.org/jira/browse/FLINK-703
> Project: Flink
> Issue Type: Improvement
> Reporter: GitHub Import
> Assignee: Chiwan Park
> Priority: Trivial
> Labels: github-import
> Fix For: pre-apache
>
>
> In some situations such as semi-joins it could make sense to use a complete
> element as join key.
> Currently this can be done using a key-selector function, but we could offer
> a shortcut for that.
> This is not an urgent issue, but might be helpful.
> ---------------- Imported from GitHub ----------------
> Url: https://github.com/stratosphere/stratosphere/issues/703
> Created by: [fhueske|https://github.com/fhueske]
> Labels: enhancement, java api, user satisfaction,
> Milestone: Release 0.6 (unplanned)
> Created at: Thu Apr 17 23:40:00 CEST 2014
> State: open
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
