Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/582#issuecomment-91327192
  
    Instead of the switch/case statement, can't you use 
`PrimitiveArrayTypeInfo.getInfoFor(Class<X> type)`? Seems simpler.
    
    Also, this is a good change to be backed by a Unit test case, rather than 
an Integration test case.
    
    I really think that such changes should be guarded by more fine grained 
tests (Unit Tests(, rather than the "big hammer" kind of test (have a 
distributed program that uses this). Out testing time goes through the roof 
otherwise.
    
    I fund that unit tests are a cycle or two more work to write, but typically 
also get you thinking better about what cases the tests should cover.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to