[
https://issues.apache.org/jira/browse/FLINK-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498044#comment-14498044
]
ASF GitHub Bot commented on FLINK-1891:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/601#discussion_r28508734
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobUtils.java ---
@@ -64,15 +64,19 @@
* @return the storage directory used by a BLOB service
*/
static File initStorageDirectory(String storageDirectory) {
- File baseDir = storageDirectory != null ?
- new File(storageDirectory) :
- new File(System.getProperty("java.io.tmpdir"));
+ File baseDir;
+ if (storageDirectory == null || storageDirectory.isEmpty()) {
--- End diff --
can you change `storageDirectory.isEmpty()` to
`storageDirectory.trim().isEmpty()` to remove all whitespaces before the
empty-check?
> Add isEmpty check when the input dir
> ------------------------------------
>
> Key: FLINK-1891
> URL: https://issues.apache.org/jira/browse/FLINK-1891
> Project: Flink
> Issue Type: Bug
> Components: Local Runtime
> Affects Versions: master
> Reporter: Sibao Hong
> Assignee: Sibao Hong
>
> Add the input storageDirectory empty check, if input of storageDirectory is
> empty, we should use tmp as the base dir
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
