Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/537#issuecomment-94167112
Hi @andralungu! Thanks for the update :-)
I left a few inline comments. Overall it looks good, I just had a little
trouble following the logic in `VertexCentricIteration` with your changes. I
think it could be simplified a bit, so that all configuration options are set
in one place. Other that that, there are some javadocs missing, please make
sure to add a description on every public method.
One concern I have is whether the `Vertex` class is the right place for the
degrees fields and methods. These should be available only inside the iteration
methods. In the current implementation one can use the public `setInDegree`
method and then retrieve the value, regardless of whether that happens inside
an iteration or whether it was set in the configuration. Could we instead
create methods inside the `VertexUpdateFunction` and `MessagingFunction`?
Something like `getVertexInDegree()` instead of `vertex.getInDegree()`? Or do
you have a better idea?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
