Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/576#issuecomment-94461019
Hi @vasia ,
The inline comments have been addressed, I still have the big comment to
look at :)
One thing(or two ^^) that could be discussed:
- the inconsistency between the iterateOn* and the reduce* method names
comes from the fact that the two methods have different behaviour: reduce takes
the elements two by two and aggregates them while iterateOn uses an iterator to
go through the edges. Hence the different names.
Imagine something like this:
Tuple2<K, Edge<K, EV>> iterateOnEdges(Tuple2<K, Edge<K, EV>> firstEdge,
Tuple2<K, Edge<K, EV>> secondEdge);
when you're not iterating on anything(or vice-versa reduceOnEdges(Iterable
edges)).
- I know ReduceEdgesFunction is not a pretty name, but I don't have another
one, ReduceFunction is already taken :P. When you think of a better name, tell
me and I can do the refactoring.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
