Github user aljoscha commented on the pull request:

    https://github.com/apache/flink/pull/439#issuecomment-95517673
  
    Hi,
    sorry for the long wait on this. I really like the feature but the 
implementation is not scalable: If new config values are added this needs to be 
updated in several places now.
    
    Could you change ConfigConstants and add a static initializer block that 
builds the hash maps that you manually build in DefaultConfigKeyValues using 
reflection. The code would just need to loop through all fields that have _KEY 
at the end, and then find the matching default value without the _KEY at the 
end. From the default value field the type of the value can be determined and 
it can be added to the appropriate hash map. This way, the defaults will always 
stay up to date with the actual config constants.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to