[ 
https://issues.apache.org/jira/browse/FLINK-924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510740#comment-14510740
 ] 

ASF GitHub Bot commented on FLINK-924:
--------------------------------------

Github user qmlmoon commented on the pull request:

    https://github.com/apache/flink/pull/35#issuecomment-95876902
  
    I rebased the PR on the current master and removed the annoying merge 
commits.


> Extend JarFileCreator to automatically include dependencies
> -----------------------------------------------------------
>
>                 Key: FLINK-924
>                 URL: https://issues.apache.org/jira/browse/FLINK-924
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Ufuk Celebi
>            Assignee: Mingliang Qi
>            Priority: Minor
>
> We have a simple {{JarFileCreator}}, which allows to add classes to a JAR 
> file as follows:
> {code:java}
> JarFileCreator jfc = new JarFileCreator(jarFile);
> jfc.addClass(X.class);
> jfc.addClass(Y.class);
> jfc.createJarFile();
> {code}
> The created file can then be used with the remote execution environment, 
> which requires a JAR file to ship.
> I propose the following improvement: use [ASM|http://asm.ow2.org/] to extract 
> all dependencies and add create the JAR file automatically.
> There is an [old tutorial|http://asm.ow2.org/doc/tutorial-asm-2.0.html] (for 
> ASM 2), which implements a {{DependencyVisitor}}. Unfortuneately the code 
> does not directly work with ASM 5, but it should be a good starting point.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to