[
https://issues.apache.org/jira/browse/FLINK-1923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513746#comment-14513746
]
ASF GitHub Bot commented on FLINK-1923:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/628
[FLINK-1923] Replaces asynchronous logging with synchronous logging in
actors
Replaces asynchronous logging with synchronous logging in actors.
Additionally, all Scala implementations are now using the grizzled-slf4j
SLF4J-wrapper which allows proper usage of SLF4J within Scala code.
One problem the grizzled-slf4j wrapper fixes is the ambiguity between
varargs and a string with two placeholders. Additionally it resolves the
ambiguity between (String, String, Object) where the first String is used as a
Marker and where the first string is the logging message.
Grizzled-slf4j adds automatically logging guards which make the explicit
checking for the log level redundant.
Grizzled-slf4j's license is BSD.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink fixLogging
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/628.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #628
----
commit 34c9fd54448b340505c97679299b8876f0257828
Author: Till Rohrmann <[email protected]>
Date: 2015-04-24T14:33:34Z
[FLINK-1923] [runtime] Replaces asynchronous logging with synchronous
logging using grizzled-slf4j wrapper for Scala.
----
> Replace asynchronous logging in JobManager with regular slf4j logging
> ---------------------------------------------------------------------
>
> Key: FLINK-1923
> URL: https://issues.apache.org/jira/browse/FLINK-1923
> Project: Flink
> Issue Type: Task
> Components: JobManager
> Affects Versions: 0.9
> Reporter: Robert Metzger
> Assignee: Till Rohrmann
>
> Its hard to understand exactly whats going on in the JobManager because the
> log messages are send asynchronously by a logging actor.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
