[ 
https://issues.apache.org/jira/browse/FLINK-1682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513773#comment-14513773
 ] 

ASF GitHub Bot commented on FLINK-1682:
---------------------------------------

Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/627#issuecomment-96580250
  
    Wow, very nice :-) Looks correct from a first glance (I did not thoroughly 
check everything).
    
    One remark: Since `print()` may become an eagerly evaluated command in the 
future, the tests become more robust when using `.output(new 
DiscardingOutputFormat())` as the sink.



> Port Record-API based optimizer tests to new Java API
> -----------------------------------------------------
>
>                 Key: FLINK-1682
>                 URL: https://issues.apache.org/jira/browse/FLINK-1682
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Optimizer
>            Reporter: Fabian Hueske
>            Assignee: Fabian Hueske
>            Priority: Minor
>             Fix For: 0.9
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to