[
https://issues.apache.org/jira/browse/FLINK-1974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14531304#comment-14531304
]
ASF GitHub Bot commented on FLINK-1974:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/652#discussion_r29796343
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/JobExecutionResult.java ---
@@ -47,12 +48,23 @@ public JobExecutionResult(JobID jobID, long netRuntime,
Map<String, Object> accu
* Gets the net execution time of the job, i.e., the execution time in
the parallel system,
* without the pre-flight steps like the optimizer.
*
- * @return The net execution time.
+ * @return The net execution time in milliseconds.
*/
public long getNetRuntime() {
return this.netRuntime;
}
+ /**
+ * Gets the net execution time of the job, i.e., the execution time in
the parallel system,
+ * without the pre-flight steps like the optimizer in a desired unit.
+ *
+ * @param desiredUnit the unit of the <tt>NetRuntime</tt>
+ * @return The net execution time in the desired unit.
+ */
+ public long elapsedNetRuntime(TimeUnit desiredUnit) {
--- End diff --
Hmm, good point. I was not aware of that.
@tillrohrmann Any particular reason why duration was changed from
milliseconds to seconds?
IMO, it would make sense to the time with a higher resolution and convert
it on need.
> JobExecutionResult NetRuntime - document result type
> ----------------------------------------------------
>
> Key: FLINK-1974
> URL: https://issues.apache.org/jira/browse/FLINK-1974
> Project: Flink
> Issue Type: Improvement
> Components: Documentation
> Affects Versions: 0.9
> Environment: The JobExecutionResult stores the net execution times in
> milliseconds, but does not say so.
> A simple fix is to add it to the JavaDoc .. a more complete fix would be to
> change the method name to getNetRuntimeMs or even use an auto conversion,
> such as getElapsedNetRuntime(Timeunit) which would autoconvert
> Reporter: Johannes
> Assignee: Johannes
> Priority: Trivial
> Labels: easyfix
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
