Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/659#discussion_r29850741
--- Diff:
flink-staging/flink-streaming/flink-streaming-connectors/src/main/java/org/apache/flink/streaming/connectors/kafka/api/KafkaSource.java
---
@@ -178,38 +182,45 @@ private void initializeConnection() {
consumerIterator = stream.iterator();
}
- /**
- * Called to forward the data from the source to the {@link DataStream}.
- *
- * @param collector
- * The Collector for sending data to the dataStream
- */
@Override
- public void run(Collector<OUT> collector) throws Exception {
- isRunning = true;
- try {
- while (isRunning && consumerIterator.hasNext()) {
- OUT out =
schema.deserialize(consumerIterator.next().message());
- if (schema.isEndOfStream(out)) {
- break;
- }
- collector.collect(out);
+ public void open(Configuration config) throws Exception {
+ initializeConnection();
+ }
+
+ @Override
+ public boolean reachedEnd() throws Exception {
+ if (nextElement != null) {
+ return true;
+ } else if (consumerIterator.hasNext()) {
+ OUT out =
schema.deserialize(consumerIterator.next().message());
+ if (schema.isEndOfStream(out)) {
+ return false;
}
- } finally {
- consumer.shutdown();
+ nextElement = out;
}
+ return false;
}
@Override
- public void open(Configuration config) throws Exception {
- initializeConnection();
+ public OUT next() throws Exception {
+ if (nextElement != null) {
+ OUT out = nextElement;
+ nextElement = null;
+ return out;
+ }
+
+ MessageWithMetadata msg;
+ OUT out = schema.deserialize(consumerIterator.next().message());
+
+ if (schema.isEndOfStream(out)) {
--- End diff --
Ah .. this event is basically an illegal state? (reachedEnd() == true,
next() called) ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
