Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/659#discussion_r29852424
  
    --- Diff: 
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/functions/source/FileSourceFunction.java
 ---
    @@ -46,39 +51,25 @@ public FileSourceFunction(InputFormat<String, ?> 
format, TypeInformation<String>
        }
     
        @Override
    +   @SuppressWarnings("unchecked")
        public void open(Configuration parameters) throws Exception {
                StreamingRuntimeContext context = (StreamingRuntimeContext) 
getRuntimeContext();
                this.provider = context.getInputSplitProvider();
                inputFormat.configure(context.getTaskStubParameters());
    +           serializer = 
typeInfo.createSerializer(getRuntimeContext().getExecutionConfig());
    --- End diff --
    
    As far as I understand the streaming code, the execution config at runtime 
is always invalid.
    
    When running a streaming job, you'll get plenty of error messages like this:
    ```
    11:26:25,600 WARN  
org.apache.flink.runtime.jobgraph.tasks.AbstractInvokable     - Environment did 
not contain an ExecutionConfig - using a default config.
    ```
    I was told that Streaming doesn't need the EC at runtime because all 
serializers are created at the client and then send over serialized.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to