[
https://issues.apache.org/jira/browse/FLINK-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14532728#comment-14532728
]
ASF GitHub Bot commented on FLINK-1977:
---------------------------------------
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/659#issuecomment-99885222
General comments:
* Let us make sure that the names are somewhat consistent with other
parts of the code. Made inline comments.
* Low watermark concept is "sneaked" into the source interfaces without
mentioning it in the description. :)
* You use `joda.time` which is inconsistent with other parts of the
streaming code. Let us avoid using two time packages.
* These changes need documentation, the source behavior is completely
changed.
> Rework Stream Operators to always be push based
> -----------------------------------------------
>
> Key: FLINK-1977
> URL: https://issues.apache.org/jira/browse/FLINK-1977
> Project: Flink
> Issue Type: Improvement
> Reporter: Aljoscha Krettek
> Assignee: Aljoscha Krettek
>
> This is a result of the discussion on the mailing list. This is an excerpt
> from the mailing list that gives the basic idea of the change:
> I propose to change all streaming operators to be push based, with a
> slightly improved interface: In addition to collect(), which I would
> call receiveElement() I would add receivePunctuation() and
> receiveBarrier(). The first operator in the chain would also get data
> from the outside invokable that reads from the input iterator and
> calls receiveElement() for the first operator in a chain.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
