Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/658#discussion_r29920868
--- Diff:
flink-core/src/test/java/org/apache/flink/api/common/io/FileInputFormatTest.java
---
@@ -18,24 +18,20 @@
package org.apache.flink.api.common.io;
-import java.io.BufferedOutputStream;
-import java.io.BufferedWriter;
-import java.io.File;
-import java.io.FileOutputStream;
-import java.io.FileWriter;
-import java.io.IOException;
+import java.io.*;
--- End diff --
As per our coding guidelines, star imports are not allowed: "Do not use
wildcard imports in the core files. They can cause problems when adding to the
code and in some cases even during refactoring. Exceptions are the Tuple
classes, Tuple-related utilities, and Flink user programs, when importing
operators/functions. Tests are a special case of the user programs."
http://flink.apache.org/coding_guidelines.html
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
