[
https://issues.apache.org/jira/browse/FLINK-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14534020#comment-14534020
]
ASF GitHub Bot commented on FLINK-1980:
---------------------------------------
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/658#discussion_r29920868
--- Diff:
flink-core/src/test/java/org/apache/flink/api/common/io/FileInputFormatTest.java
---
@@ -18,24 +18,20 @@
package org.apache.flink.api.common.io;
-import java.io.BufferedOutputStream;
-import java.io.BufferedWriter;
-import java.io.File;
-import java.io.FileOutputStream;
-import java.io.FileWriter;
-import java.io.IOException;
+import java.io.*;
--- End diff --
As per our coding guidelines, star imports are not allowed: "Do not use
wildcard imports in the core files. They can cause problems when adding to the
code and in some cases even during refactoring. Exceptions are the Tuple
classes, Tuple-related utilities, and Flink user programs, when importing
operators/functions. Tests are a special case of the user programs."
http://flink.apache.org/coding_guidelines.html
> Allowing users to decorate input streams
> ----------------------------------------
>
> Key: FLINK-1980
> URL: https://issues.apache.org/jira/browse/FLINK-1980
> Project: Flink
> Issue Type: New Feature
> Components: Core
> Reporter: Sebastian Kruse
> Assignee: Sebastian Kruse
> Priority: Minor
>
> Users may have to do unforeseeable operations on file input streams before
> they can be used by the actual input format logic, e.g., exotic compression
> formats or preambles such as byte order marks. Therefore, it would be useful
> to provide the user with a hook to decorate input streams in order to handle
> such issues.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
