Github user thvasilo commented on the pull request:
https://github.com/apache/flink/pull/656#issuecomment-100884364
Thank you Johaness. The optimization code has been merged to the master
now, so could you rebase your branch to the latest master so we can look at the
changes in an isolated way?
You can take a look at the [How to
contibute](http://flink.apache.org/how-to-contribute.html#contributing-code-&-documentation)
guide on how to do this. The merges you have currently make it hard to review
the code.
Also, please make sure all your classes have docstrings, you can take the
docstring for SquaredLoss as an example (i.e. one sentence is usually enough).
Documentation is always welcome of course, so if you want to add some more
details to the loss functions section of the ML documentation
(docs/libs/ml/optimization.md) feel free to do so in this PR.
Let me know if you run into any problems.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
