[ 
https://issues.apache.org/jira/browse/FLINK-1676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14538366#comment-14538366
 ] 

ASF GitHub Bot commented on FLINK-1676:
---------------------------------------

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/473#discussion_r30067549
  
    --- Diff: 
flink-java/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java 
---
    @@ -313,6 +319,15 @@ public int getFieldIndex(String fieldName) {
     
        @Override
        public TypeSerializer<T> createSerializer(ExecutionConfig config) {
    +           if(config.isForceKryoEnabled()) {
    +                   LOG.debug("Using KryoSerializer for serializing POJOs");
    --- End diff --
    
    I still think this is the wrong place to log this, it will get repeated a 
gazillion times on large plans. Also, it is logged in some places on the 
client, and sometimes in the runtime.
    
    It is not terribly bad, since it is debug level, but I don't get the reason 
to have it in the first place. Since you have no context information (what 
stream/dataset this is for), it is not a good debugging help anyways...


> enableForceKryo() is not working as expected
> --------------------------------------------
>
>                 Key: FLINK-1676
>                 URL: https://issues.apache.org/jira/browse/FLINK-1676
>             Project: Flink
>          Issue Type: Bug
>          Components: Java API
>    Affects Versions: 0.9
>            Reporter: Robert Metzger
>
> I my Flink job, I've set the following execution config
> {code}
> final ExecutionEnvironment env = 
> ExecutionEnvironment.getExecutionEnvironment();
> env.getConfig().disableObjectReuse();
> env.getConfig().enableForceKryo();
> {code}
> Setting a breakpoint in the {{PojoSerializer()}} constructor, you'll see that 
> we still serialize data with the POJO serializer.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to