Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/537#issuecomment-101978637
Hi @vasia,
I had a look at the new branch. The changes look good, degrees are no
longer exposed to the user and the current approach removes the need to
subclass Vertex. :+1:
The only small remark/comment I have comes from a user perspective:
- let's say that, by mistake, I forgot to set the degrees option;
- let's also say I was too "busy" to read the manual :)
- result: I will get -1 instead of the expected number of degrees per vertex
I understand why you had to pass -1 there; it should be of the same type as
the degrees. However, maybe we can come up with some way to hint users that
they should not forget to set the corresponding options. Adding an extra line
in the documentation might not suffice.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
