[ https://issues.apache.org/jira/browse/FLINK-2004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14543782#comment-14543782 ]
ASF GitHub Bot commented on FLINK-2004: --------------------------------------- GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/674 [FLINK-2004] Fix memory leak in presense of failed checkpoints for Kafka Source You can merge this pull request into a Git repository by running: $ git pull https://github.com/rmetzger/flink flink2004 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/674.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #674 ---- commit 27f11822b7db2716f3484def8ad350eb7e0b0893 Author: Robert Metzger <rmetz...@apache.org> Date: 2015-05-14T09:45:30Z [FLINK-2004] Fix memory leak in presense of failed checkpoints in Kafka source commit 36cb4758c200713a97858989ac73f117186ed9dc Author: Robert Metzger <rmetz...@apache.org> Date: 2015-05-14T13:57:18Z unused imports ---- > Memory leak in presence of failed checkpoints in KafkaSource > ------------------------------------------------------------ > > Key: FLINK-2004 > URL: https://issues.apache.org/jira/browse/FLINK-2004 > Project: Flink > Issue Type: Bug > Components: Streaming > Affects Versions: 0.9 > Reporter: Stephan Ewen > Assignee: Robert Metzger > Priority: Critical > Fix For: 0.9 > > > Checkpoints that fail never send a commit message to the tasks. > Maintaining a map of all pending checkpoints introduces a memory leak, as > entries for failed checkpoints will never be removed. > Approaches to fix this: > - The source cleans up entries from older checkpoints once a checkpoint is > committed (simple implementation in a linked hash map) > - The commit message could include the optional state handle (source needs > not maintain the map) > - The checkpoint coordinator could send messages for failed checkpoints? -- This message was sent by Atlassian JIRA (v6.3.4#6332)