[
https://issues.apache.org/jira/browse/FLINK-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14545159#comment-14545159
]
ASF GitHub Bot commented on FLINK-1977:
---------------------------------------
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/659#issuecomment-102319519
A couple of comments:
* As I see you do not introduce the PollingSourceFunction, this leads to
the following point :)
* I would have the Flume package completely commented out. Then remove
it and add a JIRA to rewrite it from scratch. This is blocked by defining the
PollingSourceFunction interface.
* The naming of the two input operators is a bit tricky currently: the
base interface is called two input stream operator and the operatorars
themselves still have the co prefix. I can be fine by both but it would be nice
if it was the same.
* I do not see the updates for the FileMonitoring function here. Do you
have them hidden somewhere? :)
> Rework Stream Operators to always be push based
> -----------------------------------------------
>
> Key: FLINK-1977
> URL: https://issues.apache.org/jira/browse/FLINK-1977
> Project: Flink
> Issue Type: Improvement
> Reporter: Aljoscha Krettek
> Assignee: Aljoscha Krettek
>
> This is a result of the discussion on the mailing list. This is an excerpt
> from the mailing list that gives the basic idea of the change:
> I propose to change all streaming operators to be push based, with a
> slightly improved interface: In addition to collect(), which I would
> call receiveElement() I would add receivePunctuation() and
> receiveBarrier(). The first operator in the chain would also get data
> from the outside invokable that reads from the input iterator and
> calls receiveElement() for the first operator in a chain.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
