[
https://issues.apache.org/jira/browse/FLINK-1848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14550382#comment-14550382
]
Laurent Tardif commented on FLINK-1848:
---------------------------------------
There also a little issue in the test that validate FileOutputFormat class.
ex : in the method testCreateNonParallelLocalFS
tmpOutFile = new File(tmpOutPath.getAbsolutePath()+"/1");
isntead of :
tmpOutFile = new File(tmpOutPath.getAbsolutePath()+File.separatorChar+"1");
For the bug : the issue happen (for me) in the mkdirs function of the
localFileSystem class when it didnot detect than file:/C/ is the root of the
filesystem.
also, it look strange not to verify at the begining of the function, that the
parameter is a directory, and that we do not need to recurse up to the root of
the filesystem to validate the path
public boolean mkdirs(final Path f) throws IOException {
if (pathToFile(f).isDirectory()) {return true ;}
> Paths containing a Windows drive letter cannot be used in FileOutputFormats
> ---------------------------------------------------------------------------
>
> Key: FLINK-1848
> URL: https://issues.apache.org/jira/browse/FLINK-1848
> Project: Flink
> Issue Type: Bug
> Affects Versions: 0.9
> Environment: Windows (Cygwin and native)
> Reporter: Fabian Hueske
> Assignee: Fabian Hueske
> Priority: Critical
> Fix For: 0.9
>
>
> Paths that contain a Windows drive letter such as {{file:///c:/my/directory}}
> cannot be used as output path for {{FileOutputFormat}}.
> If done, the following exception is thrown:
> {code}
> Caused by: java.lang.IllegalArgumentException: java.net.URISyntaxException:
> Relative path in absolute URI: file:c:
> at org.apache.flink.core.fs.Path.initialize(Path.java:242)
> at org.apache.flink.core.fs.Path.<init>(Path.java:225)
> at org.apache.flink.core.fs.Path.<init>(Path.java:138)
> at
> org.apache.flink.core.fs.local.LocalFileSystem.pathToFile(LocalFileSystem.java:147)
> at
> org.apache.flink.core.fs.local.LocalFileSystem.mkdirs(LocalFileSystem.java:232)
> at
> org.apache.flink.core.fs.local.LocalFileSystem.mkdirs(LocalFileSystem.java:233)
> at
> org.apache.flink.core.fs.local.LocalFileSystem.mkdirs(LocalFileSystem.java:233)
> at
> org.apache.flink.core.fs.local.LocalFileSystem.mkdirs(LocalFileSystem.java:233)
> at
> org.apache.flink.core.fs.local.LocalFileSystem.mkdirs(LocalFileSystem.java:233)
> at
> org.apache.flink.core.fs.FileSystem.initOutPathLocalFS(FileSystem.java:603)
> at
> org.apache.flink.api.common.io.FileOutputFormat.open(FileOutputFormat.java:233)
> at
> org.apache.flink.api.java.io.CsvOutputFormat.open(CsvOutputFormat.java:158)
> at
> org.apache.flink.runtime.operators.DataSinkTask.invoke(DataSinkTask.java:183)
> at
> org.apache.flink.runtime.execution.RuntimeEnvironment.run(RuntimeEnvironment.java:217)
> at java.lang.Thread.run(Unknown Source)
> Caused by: java.net.URISyntaxException: Relative path in absolute URI: file:c:
> at java.net.URI.checkPath(Unknown Source)
> at java.net.URI.<init>(Unknown Source)
> at org.apache.flink.core.fs.Path.initialize(Path.java:240)
> ... 14 more
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)