Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/695#issuecomment-103498471
Thank you for working on the issue. I'll soon review your changes in detail.
From what I saw by scrolling over it, it looks very good (with log messages
and documentation).
One thing that caught my attention was that the included test is not really
a unit or integration test. Its more like an example.
Do you think there is a way to turn this into a real JUnit test?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
