[
https://issues.apache.org/jira/browse/FLINK-6177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974778#comment-15974778
]
ASF GitHub Bot commented on FLINK-6177:
---------------------------------------
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3741
Thanks for contributing this, the added functionality looks good.
I would prefer to add this change without changing the dependencies and
test base classes. You could for example change the test to throw an exception
in the "validator function" if the word is not in the cache file. That way you
do not need to "collect back" the data.
Minor comment: Generating the input from a collection rather than a file
makes the tests usually a bit more lightweight. In all newer tests, we try to
do that.
> Add support for "Distributed Cache" in streaming applications
> -------------------------------------------------------------
>
> Key: FLINK-6177
> URL: https://issues.apache.org/jira/browse/FLINK-6177
> Project: Flink
> Issue Type: New Feature
> Components: DataStream API
> Reporter: Zohar Mizrahi
> Assignee: Zohar Mizrahi
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
